Baole Ni <baolex.ni@xxxxxxxxx> writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> > Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> > --- > drivers/usb/phy/phy-twl6030-usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c > index a72e8d6..4ed75c6 100644 > --- a/drivers/usb/phy/phy-twl6030-usb.c > +++ b/drivers/usb/phy/phy-twl6030-usb.c > @@ -208,7 +208,7 @@ static ssize_t twl6030_usb_vbus_show(struct device *dev, > > return ret; > } > -static DEVICE_ATTR(vbus, 0444, twl6030_usb_vbus_show, NULL); > +static DEVICE_ATTR(vbus, S_IRUSR | S_IRGRP | S_IROTH, twl6030_usb_vbus_show, NULL); line too long -- balbi
Attachment:
signature.asc
Description: PGP signature
