Re: [PATCH] usb: serial: ftdi_sio: Added 0a5c:6422 device ID for WICED USB UART dev board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 27, 2016 at 02:44:19PM -0400, Jeffrey Chu wrote:
> Signed-off-by: Jeffrey Chu <shec@xxxxxxxxxxx>

You should really put _some_ changelog comments in here, please?

> ---
>  drivers/usb/serial/ftdi_sio.c     | 1 +
>  drivers/usb/serial/ftdi_sio_ids.h | 8 ++++++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 0082080..ef19af4 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1008,6 +1008,7 @@ static const struct usb_device_id id_table_combined[] = {
>      { USB_DEVICE(ICPDAS_VID, ICPDAS_I7560U_PID) },
>      { USB_DEVICE(ICPDAS_VID, ICPDAS_I7561U_PID) },
>      { USB_DEVICE(ICPDAS_VID, ICPDAS_I7563U_PID) },
> +    { USB_DEVICE(WICED_USB_VID, WICED_USB20706V2_PID) },
>      { }                    /* Terminating entry */
>  };
> 
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h
> b/drivers/usb/serial/ftdi_sio_ids.h
> index c5d6c1e..b29f280 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -1485,3 +1485,11 @@
>  #define CHETCO_SEASMART_DISPLAY_PID    0xA5AD /* SeaSmart NMEA2000 Display */
>  #define CHETCO_SEASMART_LITE_PID    0xA5AE /* SeaSmart Lite USB Adapter */
>  #define CHETCO_SEASMART_ANALOG_PID    0xA5AF /* SeaSmart Analog Adapter */
> +
> +/*
> + * WICED USB UART
> + */
> +#define WICED_USB_VID        0x0A5C
> +#define WICED_USB20706V2_PID    0x6422
> +
> +

Why the two extra blank lines at the bottom of the file?

Also, your patch is corrupted, all tabs turned into spaces and can't be
applied.  Please fix it up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux