> I believe it is time to stop the exchange. Let Ajay update the > [3] usb: musb: Fix for kernel panic with multiple bulk transfer at http://marc.info/?l=linux-usb&m=122390068417621&w=2 > patch as he has indicated. Let us review the same and decide on the future course of action. For now let us park the discussion here. I will post the 2nd version of above patch ([3]) addressing the issues reported in it. I didn't work on this activity assuming a replacement patch coming as discussed at http://marc.info/?l=linux-usb&m=122651702219739&w=2 but now since the kernel panic issue reported by me is not being addressed in two patches ([1] and [2] from sergei) so will resume this rework and post the 2nd version of [3] very soon. Thanks to all, Ajay > regards > swami ________________________________________ From: davinci-linux-open-source-bounces@xxxxxxxxxxxxxxxxxxxx [davinci-linux-open-source-bounces@xxxxxxxxxxxxxxxxxxxx] On Behalf Of Sergei Shtylyov [sshtylyov@xxxxxxxxxxxxx] Sent: Sunday, January 25, 2009 1:37 AM To: Gupta, Ajay Kumar Cc: davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; felipe.balbi@xxxxxxxxx; gregkh@xxxxxxx Subject: Re: [PATCH 2/8] musb_host: fix endpoint_disable() method Hello, I wrote: >>>>> Sergei, was this fixed ?? > >>>> By me? No. I have enough work to do rather than fixing this corner >>>> case. E.g. I'm still busy fixing ISO Tx DMA which is certainly more >>>> important (and complex) task. > >>>>> Where's the new version of this patch ? > >>>> What? This is hardly even connected to my patch -- especially this >>>> one. > >>> What do you mean, > >>> Please read all this thread. > >>> the original patch is yours. > >>> I haven't promised to fix the corner case oops that Ajay has reported >>> (besides, I have too many other issue to deal with). And it hasn't >>> been proven >>> that it was caused by my patches. So, I'm seeing no reason for new >>> versions -- >>> this patch in particular fixed the case of an *assured* oops/lockup. > >> [1] [PATCH 2/8] musb_host: fix endpoint_disable() method at >> http://marc.info/?l=linux-usb&m=122963107004966&w=2 > >> [2] [PATCH 1/8] musb_host: fix urb_dequeue() method at >> http://marc.info/?l=linux-usb&m=122963106904957&w=2 > >> [3] usb: musb: Fix for kernel panic with multiple bulk transfer at >> http://marc.info/?l=linux-usb&m=122390068417621&w=2 > >> Two patch ([1] and [2]) from Sergei's submitted patch-list is suppose >> to be a replacement for [3] >> and is expected to solve the the kernel panic which was earlier >> getting fixed by [3] > > Well, it was your expectation only. I've claimed that they are > partial replacements, not that they'll fix your corner case. > >> but seems there is still some corner case left in [1] and [2]. > > Why not find a dn fix it if you have time? I certainly don't. And > I'm certainly not going to do all the work for everybody. > >> The kernel panic I reported doesn't happen if we use [3] above. > > If your pacth wasn't such a pile of ..., I wouldn't request pulling > it out. To which you agreed. Moreover, you said back then that I seemed to have found the cause of the issue (which you never described) your patch was dealing with. > You haven't offered us the reworked version during all these months. I have found severa; mistakes in your patch back then. Please, do me the same favor. Don't just complain that it haven't fixed you problem which I've never claimed it would. We've tackled the driver issues in different ways -- you were trying to fix your corner case failure, I was trying to fix the obviously (or not so obviously) wrong code. As to your promised new patch (I still haven't gotten your reply, and saw it only on http://marc.info), we need to see it yet... and I don't get why you said that my patches *may* need to be reveted. You're not sure or have not seen the actual fix? Stop intriguing me already. :-) > -Ajay WBR, Sergei _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
