On Thu, May 12, 2016 at 10:48:53AM +0200, Mathieu OTHACEHE wrote:
> Use usb_serial_generic_close in close callback.
>
> Signed-off-by: Mathieu OTHACEHE <m.othacehe@xxxxxxxxx>
> ---
> drivers/usb/serial/ti_usb_3410_5052.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c
> index 8350c6b..3d36ae7 100644
> --- a/drivers/usb/serial/ti_usb_3410_5052.c
> +++ b/drivers/usb/serial/ti_usb_3410_5052.c
> @@ -807,24 +807,16 @@ static void ti_close(struct usb_serial_port *port)
> {
> struct ti_device *tdev;
> struct ti_port *tport;
> - int port_number;
> int status;
> int do_unlock;
> - unsigned long flags;
>
> tdev = usb_get_serial_data(port->serial);
> tport = usb_get_serial_port_data(port);
>
> - usb_kill_urb(port->read_urb);
> - usb_kill_urb(port->write_urb);
> - spin_lock_irqsave(&tport->tp_lock, flags);
> - kfifo_reset_out(&port->write_fifo);
> - spin_unlock_irqrestore(&tport->tp_lock, flags);
> -
> - port_number = port->port_number;
> + usb_serial_generic_close(port);
This change must go with the conversion to use the generic
implementations (e.g. in order to kill both read urbs at close, etc).
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
