[PATCH v2 3/5] usb: serial: usb_wwan.c: clean up dev_dbg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



dev_dbg() already can state the function name.
No need to state it again explicitly.

Signed-off-by: Oliver Neukum <oneukum@xxxxxxxx>
---
 drivers/usb/serial/usb_wwan.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c
index 3dfdfc8..0c128a5 100644
--- a/drivers/usb/serial/usb_wwan.c
+++ b/drivers/usb/serial/usb_wwan.c
@@ -193,7 +193,7 @@ int usb_wwan_ioctl(struct tty_struct *tty,
 {
 	struct usb_serial_port *port = tty->driver_data;
 
-	dev_dbg(&port->dev, "%s cmd 0x%04x\n", __func__, cmd);
+	dev_dbg(&port->dev, "cmd 0x%04x\n", cmd);
 
 	switch (cmd) {
 	case TIOCGSERIAL:
@@ -206,7 +206,7 @@ int usb_wwan_ioctl(struct tty_struct *tty,
 		break;
 	}
 
-	dev_dbg(&port->dev, "%s arg not supported\n", __func__);
+	dev_dbg(&port->dev, "arg not supported\n");
 
 	return -ENOIOCTLCMD;
 }
@@ -226,7 +226,7 @@ int usb_wwan_write(struct tty_struct *tty, struct usb_serial_port *port,
 	portdata = usb_get_serial_port_data(port);
 	intfdata = usb_get_serial_data(port->serial);
 
-	dev_dbg(&port->dev, "%s: write (%d chars)\n", __func__, count);
+	dev_dbg(&port->dev, "write (%d chars)\n", count);
 
 	i = 0;
 	left = count;
@@ -243,7 +243,7 @@ int usb_wwan_write(struct tty_struct *tty, struct usb_serial_port *port,
 			usb_unlink_urb(this_urb);
 			continue;
 		}
-		dev_dbg(&port->dev, "%s: endpoint %d buf %d\n", __func__,
+		dev_dbg(&port->dev, "endpoint %d buf %d\n",
 			usb_pipeendpoint(this_urb->pipe), i);
 
 		err = usb_autopm_get_interface_async(port->serial->interface);
@@ -284,7 +284,7 @@ int usb_wwan_write(struct tty_struct *tty, struct usb_serial_port *port,
 	}
 
 	count -= left;
-	dev_dbg(&port->dev, "%s: wrote (did %d)\n", __func__, count);
+	dev_dbg(&port->dev, "wrote (did %d)\n", count);
 	return count;
 }
 EXPORT_SYMBOL(usb_wwan_write);
@@ -303,15 +303,15 @@ static void usb_wwan_indat_callback(struct urb *urb)
 	dev = &port->dev;
 
 	if (status) {
-		dev_dbg(dev, "%s: nonzero status: %d on endpoint %02x.\n",
-			__func__, status, endpoint);
+		dev_dbg(dev, "nonzero status: %d on endpoint %02x.\n",
+			status, endpoint);
 	} else {
 		if (urb->actual_length) {
 			tty_insert_flip_string(&port->port, data,
 					urb->actual_length);
 			tty_flip_buffer_push(&port->port);
 		} else
-			dev_dbg(dev, "%s: empty read urb received\n", __func__);
+			dev_dbg(dev, "empty read urb received\n");
 	}
 	/* Resubmit urb so we continue receiving */
 	err = usb_submit_urb(urb, GFP_ATOMIC);
@@ -369,7 +369,7 @@ int usb_wwan_write_room(struct tty_struct *tty)
 			data_len += OUT_BUFLEN;
 	}
 
-	dev_dbg(&port->dev, "%s: %d\n", __func__, data_len);
+	dev_dbg(&port->dev, "room left: %d\n", data_len);
 	return data_len;
 }
 EXPORT_SYMBOL(usb_wwan_write_room);
@@ -391,7 +391,7 @@ int usb_wwan_chars_in_buffer(struct tty_struct *tty)
 		if (this_urb && test_bit(i, &portdata->out_busy))
 			data_len += this_urb->transfer_buffer_length;
 	}
-	dev_dbg(&port->dev, "%s: %d\n", __func__, data_len);
+	dev_dbg(&port->dev, "room used: %d\n", data_len);
 	return data_len;
 }
 EXPORT_SYMBOL(usb_wwan_chars_in_buffer);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux