On Fri, Jul 08, 2016 at 01:28:57PM +0300, Felipe Balbi wrote:
>
> Hi,
>
> Peter Chen <peter.chen@xxxxxxx> writes:
> > The udc device needs to be deleted if error occurs
> >
> > Fixes: 855ed04a (usb: gadget: udc-core: independent registration of gadgets and gadget drivers)
>
> it's preferred that the abbreviation is done with 12 characters and
> commit subject be wrapped also with "". IOW:
>
> Fixes: 855ed04a3758 ("usb: gadget: udc-core: independent registration of
> gadgets and gadget drivers")"
>
Thanks, I will send v2 with above style.
Peter
> > Signed-off-by: Peter Chen <peter.chen@xxxxxxx>
> > ---
> > drivers/usb/gadget/udc/core.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> > index ff8685e..934f838 100644
> > --- a/drivers/usb/gadget/udc/core.c
> > +++ b/drivers/usb/gadget/udc/core.c
> > @@ -1145,7 +1145,7 @@ int usb_add_gadget_udc_release(struct device *parent, struct usb_gadget *gadget,
> > if (ret != -EPROBE_DEFER)
> > list_del(&driver->pending);
> > if (ret)
> > - goto err4;
> > + goto err5;
> > break;
> > }
> > }
> > @@ -1154,6 +1154,9 @@ int usb_add_gadget_udc_release(struct device *parent, struct usb_gadget *gadget,
> >
> > return 0;
> >
> > +err5:
> > + device_del(&udc->dev);
> > +
> > err4:
> > list_del(&udc->list);
> > mutex_unlock(&udc_lock);
> > --
> > 1.9.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> balbi
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
