Hi Peter, > Peter Chen <hzpeterchen@xxxxxxxxx> hat am 30. Juni 2016 um 11:30 geschrieben: > > > On Sat, Jun 25, 2016 at 08:38:58AM +0000, Stefan Wahren wrote: > > Since there is no dependency from this busy wait in the reset ISR > > we could remove it. > > > > Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx> > > --- > > drivers/usb/chipidea/udc.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c > > index fdcdcc6..bb51ae8 100644 > > --- a/drivers/usb/chipidea/udc.c > > +++ b/drivers/usb/chipidea/udc.c > > @@ -323,10 +323,6 @@ static int hw_usb_reset(struct ci_hdrc *ci) > > /* clear complete status */ > > hw_write(ci, OP_ENDPTCOMPLETE, 0, 0); > > > > - /* wait until all bits cleared */ > > - while (hw_read(ci, OP_ENDPTPRIME, ~0)) > > - udelay(10); /* not RTOS friendly */ > > - > > I think this wait is needed, you can add timeout (100ms) as > an improvement. since this isn't the only loop without a timeout this should be handled more extensively later. I'll drop this patch and resend the series. Stefan > > -- > > Best Regards, > Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
