Re: [PATCH] usb/gadget: fix gadgetfs aio support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

[auto build test WARNING on balbi-usb/next]
[also build test WARNING on v4.7-rc6 next-20160707]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Mathieu-Laurendeau/usb-gadget-fix-gadgetfs-aio-support/20160708-164431
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-s5-07081546 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/init.h:4:0,
                    from drivers/usb/gadget/legacy/inode.c:16:
   drivers/usb/gadget/legacy/inode.c: In function 'ep_aio':
   drivers/usb/gadget/legacy/inode.c:545:27: warning: comparison between pointer and integer
     if (unlikely(epdata->ep) == NULL)
                              ^
   include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/usb/gadget/legacy/inode.c:545:2: note: in expansion of macro 'if'
     if (unlikely(epdata->ep) == NULL)
     ^~
   drivers/usb/gadget/legacy/inode.c:545:27: warning: comparison between pointer and integer
     if (unlikely(epdata->ep) == NULL)
                              ^
   include/linux/compiler.h:151:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
>> drivers/usb/gadget/legacy/inode.c:545:2: note: in expansion of macro 'if'
     if (unlikely(epdata->ep) == NULL)
     ^~
   drivers/usb/gadget/legacy/inode.c:545:27: warning: comparison between pointer and integer
     if (unlikely(epdata->ep) == NULL)
                              ^
   include/linux/compiler.h:162:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> drivers/usb/gadget/legacy/inode.c:545:2: note: in expansion of macro 'if'
     if (unlikely(epdata->ep) == NULL)
     ^~
--
   In file included from /kbuild/src/stress/include/linux/init.h:4:0,
                    from /kbuild/src/stress/drivers/usb/gadget/legacy/inode.c:16:
   /kbuild/src/stress/drivers/usb/gadget/legacy/inode.c: In function 'ep_aio':
   /kbuild/src/stress/drivers/usb/gadget/legacy/inode.c:545:27: warning: comparison between pointer and integer
     if (unlikely(epdata->ep) == NULL)
                              ^
   /kbuild/src/stress/include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> /kbuild/src/stress/drivers/usb/gadget/legacy/inode.c:545:2: note: in expansion of macro 'if'
     if (unlikely(epdata->ep) == NULL)
     ^~
   /kbuild/src/stress/drivers/usb/gadget/legacy/inode.c:545:27: warning: comparison between pointer and integer
     if (unlikely(epdata->ep) == NULL)
                              ^
   /kbuild/src/stress/include/linux/compiler.h:151:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
>> /kbuild/src/stress/drivers/usb/gadget/legacy/inode.c:545:2: note: in expansion of macro 'if'
     if (unlikely(epdata->ep) == NULL)
     ^~
   /kbuild/src/stress/drivers/usb/gadget/legacy/inode.c:545:27: warning: comparison between pointer and integer
     if (unlikely(epdata->ep) == NULL)
                              ^
   /kbuild/src/stress/include/linux/compiler.h:162:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> /kbuild/src/stress/drivers/usb/gadget/legacy/inode.c:545:2: note: in expansion of macro 'if'
     if (unlikely(epdata->ep) == NULL)
     ^~

vim +/if +545 drivers/usb/gadget/legacy/inode.c

   529		ssize_t value;
   530	
   531		iocb->private = priv;
   532		priv->iocb = iocb;
   533	
   534		kiocb_set_cancel_fn(iocb, ep_aio_cancel);
   535		get_ep(epdata);
   536		priv->epdata = epdata;
   537		priv->actual = 0;
   538		priv->mm = current->mm; /* mm teardown waits for iocbs in exit_aio() */
   539	
   540		/* each kiocb is coupled to one usb_request, but we can't
   541		 * allocate or submit those if the host disconnected.
   542		 */
   543		spin_lock_irq(&epdata->dev->lock);
   544		value = -ENODEV;
 > 545		if (unlikely(epdata->ep) == NULL)
   546			goto fail;
   547	
   548		req = usb_ep_alloc_request(epdata->ep, GFP_ATOMIC);
   549		value = -ENOMEM;
   550		if (unlikely(!req))
   551			goto fail;
   552	
   553		priv->req = req;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux