Re: [PATCH] usb: ohci-at91: make at91_dt_syscon_sfr static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27/06/2016 at 10:24:59 +0100, Ben Dooks wrote :
> On 26/06/16 19:48, Greg Kroah-Hartman wrote:
> > On Fri, Jun 17, 2016 at 04:11:55PM +0100, Ben Dooks wrote:
> >> Make at91_dt_syscon_sfr() static as it is not used or declared
> >> outside the drivers/usb/host/ohci-at91.c file.
> >>
> >> drivers/usb/host/ohci-at91.c:144:15: warning: symbol 'at91_dt_syscon_sfr' was not declared. Should it be static?
> >>
> >> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> >> Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> >> Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> >> ---
> >> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >> Cc: linux-usb@xxxxxxxxxxxxxxx
> >> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> >> Cc: Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>
> >> ---
> >>  drivers/usb/host/ohci-at91.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Doesn't apply properly to my tree :(
> 
> I think the function has now been removed, but I'd need to check.
> 

Or rather, it is not in yet. I'm not sure which tree you compiled to get
it.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux