Re: [PATCH 1/1] Fix compilation errors with musb/cppi_dma.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 23, 2009 at 10:38:03AM -0500, ext Hugo Villeneuve wrote:
> These compilation errors are related to incorrect
> debugging macro and variable names and generated the
> following errors:
> 
>   drivers/usb/musb/cppi_dma.c:437:5: warning: "MUSB_DEBUG" is not defined
>   drivers/usb/musb/cppi_dma.c: In function 'cppi_next_rx_segment':
>   drivers/usb/musb/cppi_dma.c:884: error: 'debug' undeclared (first use in this function)
> 
> Signed-off-by: Hugo Villeneuve <hugo@xxxxxxxxxxx>

Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>

> ---
>  drivers/usb/musb/cppi_dma.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/musb/cppi_dma.c b/drivers/usb/musb/cppi_dma.c
> index 5ad6d08..d8d5345 100644
> --- a/drivers/usb/musb/cppi_dma.c
> +++ b/drivers/usb/musb/cppi_dma.c
> @@ -9,6 +9,7 @@
>  #include <linux/usb.h>
>  
>  #include "musb_core.h"
> +#include "musb_debug.h"
>  #include "cppi_dma.h"
>  
>  
> @@ -423,6 +424,7 @@ cppi_rndis_update(struct cppi_channel *c, int is_rx,
>  	}
>  }
>  
> +#ifdef CONFIG_USB_MUSB_DEBUG
>  static void cppi_dump_rxbd(const char *tag, struct cppi_descriptor *bd)
>  {
>  	pr_debug("RXBD/%s %08x: "
> @@ -431,10 +433,11 @@ static void cppi_dump_rxbd(const char *tag, struct cppi_descriptor *bd)
>  			bd->hw_next, bd->hw_bufp, bd->hw_off_len,
>  			bd->hw_options);
>  }
> +#endif
>  
>  static void cppi_dump_rxq(int level, const char *tag, struct cppi_channel *rx)
>  {
> -#if MUSB_DEBUG > 0
> +#ifdef CONFIG_USB_MUSB_DEBUG
>  	struct cppi_descriptor	*bd;
>  
>  	if (!_dbg_level(level))
> @@ -881,12 +884,14 @@ cppi_next_rx_segment(struct musb *musb, struct cppi_channel *rx, int onepacket)
>  	bd->hw_options |= CPPI_SOP_SET;
>  	tail->hw_options |= CPPI_EOP_SET;
>  
> -	if (debug >= 5) {
> +#ifdef CONFIG_USB_MUSB_DEBUG
> +	if (_dbg_level(5)) {
>  		struct cppi_descriptor	*d;
>  
>  		for (d = rx->head; d; d = d->next)
>  			cppi_dump_rxbd("S", d);
>  	}
> +#endif
>  
>  	/* in case the preceding transfer left some state... */
>  	tail = rx->last_processed;
> -- 
> 1.5.4.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux