Re: Re: [PATCH 1/3] usb: gadget: f_fs: handle control requests not directed to interface or endpoint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

"Felix Hädicke" <FelixHaedicke@xxxxxx> writes:
>> > Introduces a new FunctionFS descriptor flag named
>> > FUNCTIONFS_ALL_CTRL_RECIP. When this flag is enabled, control requests,
>> > which are not explicitly directed to an interface or endpoint, can be
>> > handled.
>> >
>> > This allows FunctionFS userspace drivers to process non-standard
>> > control requests.
>> >
>> > Signed-off-by: Felix Hädicke <felixhaedicke@xxxxxx>
>> 
>> can you describe a situation where this is needed? That would be
>> valuable for commit log
>
> I am developing a driver, which I would like to implement using
> FunctionFS, for using the Android Open Accessory protocol on
> non-Android devices. These accessories send some non-standard control
> requests which are described here:
> https://source.android.com/devices/accessories/aoa.html

oh cool. I was thinking about Android Accessory a couple weeks ago. I'm
not sure yet if functionfs is the best way to go here. Maybe we should
actually have a proper function (f_android_accessory.c??) so it's easier
to handle this.

Also, maybe we should add some Android folks to the loop here. Adding
android's accessory function author here.

Mike, I'm looking at [1]. Do you have any interest in getting that
upstream? Also, taking the opportunity to raise another question: I
noticed android's MTP is pretty darn slow, I'm assuming the limitation
is functionfs itself. Do you wanna see how we can make that faster?

cheers

[1] https://android.googlesource.com/kernel/common/+/android-4.4/drivers/usb/gadget/function/f_accessory.c

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux