Re: [PATCH 1/3] usb: musb: fix bug in musb_free() w.r.t free_irq()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 07, 2009 at 04:43:49PM +0530, Ajay Kumar Gupta wrote:
> Fixes insert module failure as free_irq() was not
> done in previous rmmod.
> 
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@xxxxxx>

Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>

> ---
>  drivers/usb/musb/musb_core.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index f71fab6..2447e3a 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1824,8 +1824,9 @@ static void musb_free(struct musb *musb)
>  	musb_gadget_cleanup(musb);
>  #endif
>  
> -	if (musb->nIrq >= 0 && musb->irq_wake) {
> -		disable_irq_wake(musb->nIrq);
> +	if (musb->nIrq >= 0) {
> +		if (musb->irq_wake)
> +			disable_irq_wake(musb->nIrq);
>  		free_irq(musb->nIrq, musb);
>  	}
>  	if (is_dma_capable() && musb->dma_controller) {
> -- 
> 1.5.6

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux