On 20 June 2016 at 16:15, Felipe Balbi <balbi@xxxxxxxxxx> wrote: > Baolin Wang <baolin.wang@xxxxxxxxxx> writes: > >> It will be crash to stop gadget when the dwc3 device had been into suspend >> state, thus we need to check if the dwc3 device had been into suspend state >> when UDC try to stop gadget. >> >> By the way I have rebased on your 'testing/next' branch. > > do you really want this note to be in commit log? Seems like this should > be after tearline below. Sorry. I'll remove this in next version. Thanks for your comment. > >> >> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx> >> --- >> drivers/usb/dwc3/gadget.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index 6dde376..351769e 100644 >> --- a/drivers/usb/dwc3/gadget.c >> +++ b/drivers/usb/dwc3/gadget.c >> @@ -1791,6 +1791,9 @@ err0: >> >> static void __dwc3_gadget_stop(struct dwc3 *dwc) >> { >> + if (pm_runtime_suspended(dwc->dev)) >> + return; >> + >> dwc3_gadget_disable_irq(dwc); >> __dwc3_gadget_ep_disable(dwc->eps[0]); >> __dwc3_gadget_ep_disable(dwc->eps[1]); >> -- >> 1.7.9.5 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > balbi -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html