I did some test-builds with W=1 and the -Wunused-but-set-variable warnings appeared to be all fairly easy to address. In tons of randconfig builds, I only found five instances. The warning was originally disabled by Dave Jones when we hit more instances with gcc-4.6, but apparently most of those have gotten addressed anyway. All five patches can be applied independently, and in each case, the original code is not wrong, but the assignments are also useless, so I'd consider this warning marginally useful. I have a few other patch series for W=1 issues, and we can consider turning those on by default once all the patches are merged. Arnd Arnd Bergmann (5): net: qlcnic: don't set unused function argument net: tlan: don't set unused function argument mic: remove unused function arg usb: pxa27x_udc: remove unused function argument fbmon: remove unused function argument drivers/misc/mic/scif/scif_dma.c | 6 ++---- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 1 - drivers/net/ethernet/ti/tlan.c | 1 - drivers/usb/gadget/udc/pxa27x_udc.c | 9 +++------ drivers/video/fbdev/core/fbmon.c | 1 - 5 files changed, 5 insertions(+), 13 deletions(-) -- 2.9.0 Cc: Sudeep Dutt <sudeep.dutt@xxxxxxxxx> Cc: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx> Cc: Dept-GELinuxNICDev@xxxxxxxxxx Cc: Samuel Chessman <chessman@xxxxxxx> Cc: Felipe Balbi <balbi@xxxxxxxxxx> Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx> Cc: netdev@xxxxxxxxxxxxxxx Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx Cc: linux-usb@xxxxxxxxxxxxxxx Cc: linux-fbdev@xxxxxxxxxxxxxxx Cc: Dave Jones <davej@xxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
