Re: [PATCH] usb: common: otg-fsm: add license to usb-otg-fsm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 14, 2016 at 01:26:59PM +0200, Oscar wrote:
> El 2016-06-14 08:26, Peter Chen escribió:
> >On Mon, Jun 13, 2016 at 06:56:30PM +0200, Oscar wrote:
> >>Fix warning about tainted kernel because usb-otg-fsm has no license.
> >>WARNING: with this patch usb-otg-fsm module can be loaded
> >>but then the kernel will hang. Tested with a udoo quad board.
> >>
> >>Signed-off-by: Oscar Curero <oscar@xxxxxxxxxxxx>
> >>---
> >> drivers/usb/common/usb-otg-fsm.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >>diff --git a/drivers/usb/common/usb-otg-fsm.c
> >>b/drivers/usb/common/usb-otg-fsm.c
> >>index 9059b7d..2f537bb 100644
> >>--- a/drivers/usb/common/usb-otg-fsm.c
> >>+++ b/drivers/usb/common/usb-otg-fsm.c
> >>@@ -21,6 +21,7 @@
> >>  * 675 Mass Ave, Cambridge, MA 02139, USA.
> >>  */
> >>
> >>+#include <linux/module.h>
> >> #include <linux/kernel.h>
> >> #include <linux/types.h>
> >> #include <linux/mutex.h>
> >>@@ -450,3 +451,4 @@ int otg_statemachine(struct otg_fsm *fsm)
> >>        return fsm->state_changed;
> >> }
> >> EXPORT_SYMBOL_GPL(otg_statemachine);
> >>+MODULE_LICENSE("GPL");
> >>--
> >
> >I don't know why I can't apply your patch, does it make on
> >an very old version?
> >
> >I apply it manually, thanks.
> 
> Hi Peter,
> 
> Thanks for applying my first patch to linux! :)
> 
> As I said on the commit message, although I can load ci_hdrc_imx
> just fine, it doesn't work because as soon as it's loaded, the
> kernel hangs without any error or message at all.
> 
> This happens on my udoo quad board (imx6q). Of course, if I
> blacklist the ci_hdrc_imx module (appending
> modprobe.blacklist=ci_hdrc_imx as boot parm) I can login the system,
> but no usb devices are found. Alexander Graf from Suse said that
> this sounds like a clock problem.
> 
> Let me know how can I help you to resolve the problem.
> 

I know your problem, below patch set should fix your problem:

http://lists.infradead.org/pipermail/linux-arm-kernel/2016-March/413331.html

But this patch set is objected due to the DT description. I am working
on it using generic power sequence driver, I will add you to cc list,
it will be great if you can help me test it

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux