On Sun, Jun 12, 2016 at 10:40:55PM +0200, Lars Täuber wrote:
> Hello kernel hackers,
>
> please excuse the way I'm writing this. I know I'm for sure braking rules.
> I'm trying to use the usbip vhcd_hcd driver to monitor a beehive via an exported usb mic. Usbip is great, because I can use a very small router running openwrt and export the mic via usbip. Thanks for it!
>
> The usbip README said patches should be sent to Greg Kroah-Hartman but in the MAINTAINERS file you all are mentioned. So please excuse me for writing to you all.
>
> USBIP works just as expected. But the driver on the client side polutes the kernel ring buffer (and syslog) with this message:
> [...]
> [ 8761.874551] vhci_hcd: Not yet implemented
> [ 8761.875561] vhci_hcd: Not yet implemented
> [ 8761.876558] vhci_hcd: Not yet implemented
> [ 8761.877704] vhci_hcd: Not yet implemented
> [ 8761.878592] vhci_hcd: Not yet implemented
> [...]
>
> This is annoying because I want to record the sound inside the beehive for at least one complete year.
> The function that is printing this must be:
>
> drivers/usb/usbip/vhci_hcd.c (lines 942ff):
> static int vhci_get_frame_number(struct usb_hcd *hcd)
> {
> pr_err("Not yet implemented\n");
> return 0;
> }
>
>
> It would be nice if you could add some lines like this:
> usbip: vhci_get_frame_number
> static int vhci_get_frame_number(struct usb_hcd *hcd)
> {
> static unsigned int to_be_seen = 5;
>
> if (to_be_seen) {
> pr_err("Not yet implemented\n");
> to_be_seen--;
> }
> return 0;
> }
>
>
> I'm not a programer nor do I know if this compiles. I can't test this, because the server is a standard ubuntu LTS server. I don't want it to run kernels made by me.
> Maybe a module parameter option or something complete different is the better solution.
> I'm just a linux user.
>
> Thank you again for this great driver and all the open source you're creating!
> Have a good time.
Can you test the patch below to see if it helps with this?
thanks,
greg k-h
-------------------
>From foo@baz Tue Jun 14 13:39:19 PDT 2016
Date: Tue, 14 Jun 2016 13:39:19 -0700
To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Subject: [PATCH] usbip: rate limit get_frame_number message
It's annoying to constantly see the same "Not yet implemented" message
over and over with nothing able to be done about it, so rate limit it
for now to keep user's logs "clean".
Reported-by: Lars Täuber <lars.taeuber@xxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index fca51105974e..2e0450bec1b1 100644
--- a/drivers/usb/usbip/vhci_hcd.c
+++ b/drivers/usb/usbip/vhci_hcd.c
@@ -941,7 +941,7 @@ static void vhci_stop(struct usb_hcd *hcd)
static int vhci_get_frame_number(struct usb_hcd *hcd)
{
- pr_err("Not yet implemented\n");
+ dev_err_ratelimited(&hcd->self.root_hub->dev, "Not yet implemented\n");
return 0;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
