Re: possible hcpriv leak on ehci

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Tuesday 20 January 2009 16:25:03 schrieb Alan Stern:
> On Tue, 20 Jan 2009, Oliver Neukum wrote:
> 
> > Hi,
> > 
> > I put a check into usb-serial:
> > 
> > 	usb_kill_urb(port->read_urb);
> > 	usb_kill_urb(port->interrupt_in_urb);
> > 	WARN_ON(port->interrupt_in_urb->hcpriv != NULL);
> > 
> > and it triggered. I'll investigate this, but I have an appointment right now.
> > Do we leak private memory or just forget to clear a pointer?
> 
> Hard to say exactly what happened.  You could try moving the WARN_ON
> into the completion handler.

I did that and it turns out that usb_kill_urb() is broken. It no longer
prevents a completion handler from resubmitting itself. Did we not
recently merged a patch that touched usb_unlink_urb()?

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux