Hi, Peter Chen <hzpeterchen@xxxxxxxxx> writes: > On Tue, May 31, 2016 at 02:58:33PM +0300, Felipe Balbi wrote: >> instead of defining all functions as static inlines, >> let's move them to udc-core and export them with >> EXPORT_SYMBOL_GPL, that way we can make sure that >> only GPL drivers will use them. >> > > One concern, current some other modules may use usb gadget symbol, > like drivers/power/isp1704_charger.c uses usb_gadget_connect. > If udc-core is built as module, it may has some build issues. oh man, more dependency problems... I'll patch that up. drivers/power/isp1704_charger.c should also be M when udc-core is M. >> As a side effect, it'll be nicer to add tracepoints >> to the gadget API. > > Why it is a side effect? consequence -- balbi
Attachment:
signature.asc
Description: PGP signature
