On Wed, May 4, 2016 at 2:57 AM, Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> wrote: > > Hi, > > Rajesh Bhagat <rajesh.bhagat@xxxxxxx> writes: >> On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly set >> to be able to do DMA allocations, so use the of_dma_configure() helper >> to populate the dma properties and assign an appropriate dma_ops. >> >> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@xxxxxxx> >> Reviewed-by: Yang-Leo Li <leoyang.li@xxxxxxx> > > Cool, nxp is also using dwc3 :-) C'mon Rajesh, send us a glue layer :) > >> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c >> index c679f63..4d5b783 100644 >> --- a/drivers/usb/dwc3/host.c >> +++ b/drivers/usb/dwc3/host.c >> @@ -17,6 +17,7 @@ >> >> #include <linux/platform_device.h> >> #include <linux/usb/xhci_pdriver.h> >> +#include <linux/of_device.h> >> >> #include "core.h" >> >> @@ -32,6 +33,9 @@ int dwc3_host_init(struct dwc3 *dwc) >> return -ENOMEM; >> } >> >> + if (IS_ENABLED(CONFIG_OF) && dwc->dev->of_node) >> + of_dma_configure(&xhci->dev, dwc->dev->of_node); > > okay, so we have a long discussion about this going on. You can catch up > with it starting here: > > http://marc.info/?i=1461612094-30939-1-git-send-email-grygorii.strashko@xxxxxx > > At least for now, this patch will be applied. We need to have a better > solution for this, one that helps not only DT platforms. Balbi, Has the patch from Grygorii been applied? I don't see it in the mainline tree yet. Without fix, the dwc3 driver will fail for all ARM64 SoCs. Regards, Leo -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
