On Sat, 2009-01-17 at 14:21 +0100, Rafael J. Wysocki wrote: > On Saturday 17 January 2009, Benjamin Herrenschmidt wrote: > > > > > Not exactly. Just try this patch: > > > > > > http://marc.info/?l=linux-kernel&m=123184641714487&w=2 > > > > > > with vanilla 2.6.29-rc1 or rc2. > > > > Out of curiosity, while pci_disable_device() before save_state() ? > > Because on resume we call pci_restore_state() before pci_(re)enable_device(). But that doesn't sound correct to me. In some cases, pci_enable_device() is hooked by the architecture to effectively turn on the device, ie, enable clocks or power, etc... I've seen embedded stuff like that and some PowerMac devices do that too (though not those USB ones in that specific case). I think nothing should happen before pci_enable_device() Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
