Re: [PATCH 00/13] usb: dwc2: Fix up gadget isochronous support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/18/2016 3:44 AM, John Keeping wrote:
> On Tue, 17 May 2016 16:16:23 -0700, John Youn wrote:
> 
>> The following patch series fixes up isochronous support for the dwc2
>> gadget. The existing isochronous support lacked a few features. Most
>> notably it did not properly sync up with the first packet and it
>> didn't handle the Incomplete ISO IN/OUT interrupts.
>>
>> These patches have been sitting in our internal tree for a while and
>> tested mostly on a HAPS-based FPGA IP validation platform.
> 
> Tested-by: John Keeping <john@xxxxxxxxxxxx>

Thanks for testing.

> 
> on Rockchip RK3288 (Radxa Rock2 Square).  With these patches the UAC2
> gadget works smoothly.
> 
> I did spot a couple of errors getting logged, but they don't seem to
> stop isochronous transfers working and I don't think they're new so they
> shouldn't block this series.  When setting up a gadget via configfs, I
> consistently get:
> 
>     dwc2 ff580000.usb: dwc2_hsotg_enqueue_setup: failed queue (-11)

We can add a check for this to suppress the error in a separate fix.

> 
> I also occasionally see:
> 
>     dwc2 ff580000.usb: GOUTNakEff triggered
> 
> when cancelling audio playback, which I guess is expected, so maybe that
> just needs to be demoted to debug level.

Yup, that message should be downgraded.

Regards,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux