Re: [PATCH] usb: echi-hcd: Add register access check in shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 18/05/16 15:56, Alan Stern wrote:
This doesn't seem like the right place.  What you really should do is
skip calling ehci_silence_controller() if the hardware isn't
accessible.  That's where the hardware gets touched, not in
ehci_shutdown().

Just tried this suggestion, this would not work as well, Its not just the hardware registers, which are of concern here, but also the rest of the things like ehci->hrtimer pointer which are allocated or initialized as part of ehci_setup().

Either the msm controller driver is not correct or we should have a way to stop calling ehci_shutdown() if there was no ehci_setup() done yet.

Any suggestions?


--srini
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux