Re: [PATCH] Add support for Juniper SRX 1500 Console via Miniusb.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 13, 2016 at 01:55:40PM +0200, Johannes Hofmann wrote:

No commit message?

> Signed-off-by: Johannes Hofmann <rhasti@xxxxxxxxx>
> ---
>  drivers/usb/serial/pl2303.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h
> index e3b7af8..60a9a5f 100644
> --- a/drivers/usb/serial/pl2303.h
> +++ b/drivers/usb/serial/pl2303.h
> @@ -149,3 +149,6 @@
>  #define SMART_VENDOR_ID	0x0b8c
>  #define SMART_PRODUCT_ID	0x2303
>  
> +/* Juniper Networks BX Series System Console */
> +#define SMART_VENDOR_ID	0x10c4
> +#define SMART_PRODUCT_ID	0x8470

You must not redefine the SMART IDs like this since that means you
just removed support for another class of devices from the pl2303
driver.

Also 0x10c4 is the SiLabs/Cygnal vendor id so I think this might be a
cp210x device which should be handled by that driver.

Try adding an entry in the cp210x device-id table instead.

Also make sure to CC the linux-usb list (added on CC) when resending.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux