On Mon, May 02, 2016 at 11:43:30AM +0300, Roger Quadros wrote: > On 29/04/16 11:24, Dirk Gouders wrote: > > If choices consist of choice_values of type tristate that depend on > > symbols set to 'm', those choice_values are not set to 'n' if the > > choice is changed from 'm' to 'y' (in which case only one active > > choice_value is allowed). Those values are also written to the config > > file causing modules to be built when they should not. > > > > The following config can be used to reproduce and examine the problem; > > with the frontend of your choice set "Choice 0" and "Choice 1" to 'm', > > then set "Tristate Choice" to 'y' and save the configuration: > > > > config modules > > boolean modules > > default y > > option modules > > > > config dependency > > tristate "Dependency" > > default m > > > > choice > > prompt "Tristate Choice" > > default choice0 > > > > config choice0 > > tristate "Choice 0" > > > > config choice1 > > tristate "Choice 1" > > depends on dependency > > > > endchoice > > > > This patch sets tristate choice_values' visibility that depend on > > symbols set to 'm' to 'n' if the corresponding choice is set to 'y'. > > > > This makes them disappear from the choice list and will also cause the > > choice_values' value set to 'n' in sym_calc_value() and as a result > > they are written as "not set" to the resulting .config file. > > > > Reported-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > > Signed-off-by: Dirk Gouders <dirk@xxxxxxxxxxx> > > Tested-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > > --- > > v5: This patch should handle tristate choice-values, only. > > > > I assumed that only tristate choice-values can have visibility 'm', > > which was wrong: tristate dependencies can result in 'm' > > visibility. > > > > So, add an explicit test if a symbol is of type tristate. > > > > I am a bit unsure how to handle Tested-By credits when patches change > > substantially and left the credits untouched but new test reports > > are welcome. > > If you made a non cosmetic change old Tested-By tags aren't valid. > > > > > --- > > The USB gadget case works fine for me. Thanks :) > > Tested-by: Roger Quadros <rogerq@xxxxxx> Applied to kbuild.git#kconfig. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
