Re: [PATCH] usb: misc: usbtest: fix pattern tests for scatterlists.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> writes:
> On Fri, 6 May 2016, Felipe Balbi wrote:
>
>> >> that's not a good idea, IMO. HCD drivers should be robust enough in
>> >> these situations.
>> >
>> > Why?  Just so that hcd-tests.sh can complete with no errors?  I don't 
>> 
>> and some off-the-shelf usb-network adapters can work ;-)
>> 
>> > know of any actual drivers or user programs that do real work and need 
>> > such small SG entry sizes.
>> 
>> Well, apparently some ASIX network adapters fail similarly, but perhaps
>> they provide sg entries big enough to be split without any memcpy() ? Dunno.
>
> Has anybody tried running one of these network adapters under EHCI?

dunno

>> > Your counterexample isn't really testusb; it's hcd-tests.sh.  I haven't 
>> > tried running that.
>> 
>> That just calls testusb and is the same test.sh from many, many years
>> ago which Dave wrote. At [1] you can find Dave's usbtest page on
>> linux-usb.org and at [2] you can find a direct link to test.sh.
>
> Okay.  Still, the fact remains that I haven't tried test.sh.  Only 
> testusb run directly from the command line.

well, then EHCI has been broken for the past 15 years or so :-) Luckily
Mathias has a fix which, potentially, can be made generic.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux