> From: Mathias Nyman
> Sent: 03 May 2016 12:11
...
> > @@ -109,7 +109,7 @@ static int last_trb(struct xhci_hcd *xhci, struct xhci_ring *ring,
> > struct xhci_segment *seg, union xhci_trb *trb)
> > {
> > if (ring == xhci->event_ring)
> > - return trb == &seg->trbs[TRBS_PER_SEGMENT];
> > + return trb == &seg->trbs[TRBS_PER_SEGMENT - 1];
> > else
> > return TRB_TYPE_LINK_LE32(trb->link.control);
> > }
> >
>
> Thanks, this needs to be fixed, but there are some changes needed to inc_enq()
> as well together with this fix.
> Otherwise the last TRB of a event ring won't be used
Is it worth using separate functions for the event rings?
I remember looking at it a long time ago and almost all the call sites
know what sort of ring they have.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
