> -----Original Message----- > From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb- > owner@xxxxxxxxxxxxxxx] On Behalf Of Johan Hovold > Sent: Wednesday, May 04, 2016 02:29 > To: Konstantin Shkolnyy > Cc: johan@xxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: [EXT] Re: [PATCH v4 2/3] USB: serial: cp210x: Got rid of magic > numbers in CRTSCTS flag code. > > On Tue, May 03, 2016 at 07:52:23PM -0500, Konstantin Shkolnyy wrote: > > Replaced magic numbers used in the CRTSCTS flag code with symbolic > names > > from the chip specification. > > > > Signed-off-by: Konstantin Shkolnyy <konstantin.shkolnyy@xxxxxxxxx> > > This patch does not even compile. Please be more careful when > resubmitting. There are at least two compilation errors below. Sorry about that. It's a couple of dumb syntax errors that don't really matter for change review purpose. Otherwise, do the patches look good? I [...] -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html