Re: [PATCH] usb: misc: usbtest: fix pattern tests for scatterlists.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> writes:
> On Mon, 2 May 2016, Mathias Nyman wrote:
>
>> The current implemenentation restart the sent pattern for each entry in
>> the sg list. The receiving end expects a continuous pattern, and test
>> will fail unless scatterilst entries happen to be aligned with the
>> pattern
>
> Ah.  We didn't spot this earlier because for non-xHCI controllers, the 
> scatterlist entries _must_ be aligned with the maxpacket size and 
> therefore with the pattern.

interesting. We actually found a similar issue with XHCI. scatterlist
has to be aligned to wMaxPacketSize but only before a link TRB. Mathias
has been working on a solution which involves memcpy()ing enough bytes
to align to wMaxPacketSize before the link TRB (it's very infrequent as
we have 256 TRBs per segment on XHCI), but if you know of a nicer way,
we're all ears :-)

/me goes dig EHCI

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux