Re: [PATCH] fix data toggle mismatch, after driver unbinding without toggle reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 14 Jan 2009, Dan Streetman wrote:

> Ok, you mean in the disable_endpoint path to avoid calling
> usb_hcd_disable_endpoint since in some cases it shouldn't really
> disable it?  And therefore the HCD leaves its qh or ed on the
> schedule, and so doesn't lose track of the toggle.

Right.

> Will avoiding the call to usb_hcd_disable_endpoint have other
> unintended side effects?

No side effects, other than the fact that the endpoint state still 
exists in the HCD.  So we have to make sure that eventually we do call 
usb_hcd_disable_endpoint.  The patch takes care of that.

> Ah whoops, I didn't notice your attached patch was new, I assumed it
> was the original ;-)
> 
> That patch looks like it will do the trick.  I'll try it out.

Thanks.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux