Re: [PATCH] usb: misc: usbtest: fix pattern tests for scatterlists.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx> writes:
> The current implemenentation restart the sent pattern for each entry in
                               ^^^^^^^
                               restarts

> the sg list. The receiving end expects a continuous pattern, and test
> will fail unless scatterilst entries happen to be aligned with the
> pattern
         ^
         . (missing a period)

> Fix this by calculating the pattern byte based on total sent size
> instead of just the current sg entry.
>
> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>

thanks for finding and fixing this really, really old bug. It seems like
we should add:

Fixes: 8b5249019352 ("[PATCH] USB: usbtest: scatterlist OUT data pattern testing")
Cc: <stable@xxxxxxxxxxxxxxx> # v2.6.18+

Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux