Re: [PATCH] USB: EHCI: make all debugging depend on CONFIG_DYNAMIC_DEBUG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 28 Apr 2016, Greg KH wrote:

> On Fri, Apr 15, 2016 at 12:12:26PM -0400, Alan Stern wrote:
> > The debugging facilities in ehci-dbg.c follow an uneven pattern.  Some
> > of them are protected by "#ifdef CONFIG_DYNAMIC_DEBUG" and some
> > aren't, presumably in the hope of having some of the debugging output
> > available in any configuration.
> > 
> > This leads to build problems when dynamic debugging isn't configured.
> > Rather than try to keep this complicated state of affairs, let's just
> > make everything dependent on CONFIG_DYNAMIC_DEBUG.
> > 
> > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > Tested-by: Rafał Miłecki <zajec5@xxxxxxxxx>
> > 
> > ---
> > 
> > 
> > [as1799]
> > 
> > 
> >  drivers/usb/host/ehci-dbg.c |   80 +++++++++++++++++++-------------------------
> >  drivers/usb/host/ehci.h     |    5 --
> >  2 files changed, 35 insertions(+), 50 deletions(-)
> 
> This doesn't apply to the tree at all, did I mess something up?

No, I did.  The patch wasn't made against the most recent source tree, 
and it turns out that several recent commits by Geyslan G. Bem touched 
the same code.  I'll send v2 shortly.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux