Hi
On 04/27/2016 07:18 AM, Felipe Balbi wrote:
>
> Hi,
>
> Krzysztof Opasiak <k.opasiak@xxxxxxxxxxx> writes:
>> From: Igor Kotrasinski <i.kotrasinsk@xxxxxxxxxxx>
>>
>> Add endpoints definitions and ops for both endpoints and gadget.
>> Add also a suitable platform driver and functions for handling
>> usbip events.
>>
>> This commit is a result of cooperation between Samsung R&D Institute
>> Poland and Open Operating Systems Student Society at University
>> of Warsaw (O2S3@UW) consisting of:
>>
>> Igor Kotrasinski <ikotrasinsk@xxxxxxxxx>
>> Karol Kosik <karo9@xxxxxxxxxx>
>> Ewelina Kosmider <3w3lfin@xxxxxxxxx>
>> Dawid Lazarczyk <lazarczyk.dawid@xxxxxxxxx>
>> Piotr Szulc <ps347277@xxxxxxxxxxxxxxxxxxxxx>
>>
>> Tutor and project owner:
>> Krzysztof Opasiak <k.opasiak@xxxxxxxxxxx>
>>
>> Signed-off-by: Igor Kotrasinski <i.kotrasinsk@xxxxxxxxxxx>
>> Signed-off-by: Karol Kosik <karo9@xxxxxxxxxx>
>> [Various bug fixes, improvements and commit msg update]
>> Signed-off-by: Krzysztof Opasiak <k.opasiak@xxxxxxxxxxx>
>
> just a couple minor nits below. Nice work
>
>> +struct vep *find_endpoint(struct vudc *udc, u8 address)
>
> polluting namespace. Care to add 'static'?
Unfortunately this cannot be static as it is used in different files.
$ cd $KERN_DIR/drivers/usb/usbip
$ git grep -l find_endpoint
vudc.h
vudc_dev.c
vudc_rx.c
vudc_transfer.c
of course I can make it static inline and put it into header but I'm not
sure if this makes any sense for this function?
>
>> +static void vep_free_request(struct usb_ep *_ep, struct usb_request *_req)
>> +{
>> + struct vrequest *req;
>> +
>> + if (!_ep || !_req) {
>> + WARN_ON(1);
>> + return;
>> + }
>
> if (WARN_ON(!_ep || !_req))
> return;
>
Sorry I missed this one. Fixed. Thanks
--
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
