Hi > -----Original Message----- > From: Peter Chen [mailto:hzpeterchen@xxxxxxxxx] > Sent: Monday, April 25, 2016 2:23 PM > To: Jun Li <jun.li@xxxxxxx> > Cc: Peter Chen <peter.chen@xxxxxxx>; linux-usb@xxxxxxxxxxxxxxx; > baolin.wang@xxxxxxxxxx > Subject: Re: [PATCH 5/5] doc: usb: ci-hdrc-usb2: add property usb-charger- > detection > > On Mon, Apr 18, 2016 at 04:17:49PM +0800, Li Jun wrote: > > Set this property if your usb module has usb charger detect function > > and you want to use it. > > > > Signed-off-by: Li Jun <jun.li@xxxxxxx> > > --- > > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > > b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > > index 1084e2b..52d269e 100644 > > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > > @@ -76,6 +76,8 @@ Optional properties: > > needs to make sure it does not send more than 90% > > maximum_periodic_data_per_frame. The use case is multiple > transactions, but > > less frame rate. > > +- usb-charger-detection: use usb charger detect function provided by > > +usb > > + module; if your usb charger type detection done by PMIC, don't enable > this. > > > > If the user doesn't set it at dts, and detection is done by PMIC, would > you show us the flow how it work at chipidea driver? This patch set only focus on charger type detection by usb module, so PMIC case may not benefit from it. 1. If user is sure the charger detection process can't impact the usb gadget enumeration, e.g. charger detection is automatically done before vbus is detected(like Baolin's case), nothing needs added at chipidea driver. Otherwise 2. We need a simple sync, wait the PMIC driver gets charger type before do gadget connect, this can be done in udc.c via power_supply_get_property() like what Baolin does in usb_charger_get_type_by_others() in charger.c. I intend to add the handling of case 2 by the real user of it. Li Jun > > -- > > Best Regards, > Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
