On Thu, Apr 21, 2016 at 02:01:47PM +0300, Felipe Balbi wrote:
> > @@ -169,20 +161,21 @@ static int dwc3_pci_probe(struct pci_dev *pci,
> > return ret;
> > }
> >
> > - pci_set_drvdata(pci, dwc3);
> > - ret = dwc3_pci_quirks(pci);
> > - if (ret)
> > - goto err;
> > -
> > dwc3->dev.parent = dev;
> > ACPI_COMPANION_SET(&dwc3->dev, ACPI_COMPANION(dev));
> >
> > + ret = dwc3_pci_quirks(pci, dwc3);
> > + if (ret)
> > + goto err;
> > +
>
> do you mind moving this hunk ...
>
> > ret = platform_device_add(dwc3);
> > if (ret) {
> > dev_err(dev, "failed to register dwc3 device\n");
> > goto err;
> > }
> >
> > + pci_set_drvdata(pci, dwc3);
>
> and this hunk to a separate patch ? They look like extra noise here
> which takes away from the actual work of $subject
Sure thing.
Thanks,
--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
