Hi, Mathieu Laurendeau <mat.lau@xxxxxxxxxxx> writes: > On 2016-04-20 09:27, Mathieu Laurendeau wrote: >> On 2016-03-23 12:51, Mathieu Laurendeau wrote: >>> Since commit 7fe3976e0f3ab26f8ffd9430d3d2a19a70f2c8d2 ("gadget: switch >>> ep_io_operations to ->read_iter/->write_iter") io submissions fail >>> with >>> ENODEV. >>> >>> Signed-off-by: Mathieu Laurendeau <mat.lau@xxxxxxxxxxx> >>> --- >>> drivers/usb/gadget/legacy/inode.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/usb/gadget/legacy/inode.c >>> b/drivers/usb/gadget/legacy/inode.c >>> index 5cdaf01..416f1017 100644 >>> --- a/drivers/usb/gadget/legacy/inode.c >>> +++ b/drivers/usb/gadget/legacy/inode.c >>> @@ -542,7 +542,7 @@ static ssize_t ep_aio(struct kiocb *iocb, >>> */ >>> spin_lock_irq(&epdata->dev->lock); >>> value = -ENODEV; >>> - if (unlikely(epdata->ep)) >>> + if (unlikely(epdata->ep == NULL)) >>> goto fail; >>> >>> req = usb_ep_alloc_request(epdata->ep, GFP_ATOMIC); >> >> Hello, >> >> Please consider reading and applying this patch. >> >> Regards, >> Mathieu Laurendeau > > I guess this got lost because of a wrong CC. yeah, I don't have the original patch in my inbox anymore, care to resend rebased on testing/next ? Also, make sure to add proper: Fixes: 7fe3976e0f3a ("gadget: switch ep_io_operations to ->read_iter/->write_iter") and: Cc: <stable@xxxxxxxxxxxxxxx> # v4.0+ to your commit log -- balbi
Attachment:
signature.asc
Description: PGP signature