Hello, I wrote:
For all of you who are patching musb, I just flushed my musb queue,
following are my pending patches that are queued up for 2.6.29, if I
forgot any of you, please resend the patch.
I'll start putting my queue every friday on the address:
http://felipebalbi.com/patches/musb
still nothing there, this friday will appear the first tarball.
I'm still getting 404.
Ajay Kumar Gupta (3):
usb: musb: Support for high bandwidth isochronous transfer
musb: NAK timeout scheme on bulk reserved ep
Ajay, I have a suggestion on this patch. The following code:
+ list_del(&cur_qh->ring);
+ list_add_tail(&cur_qh->ring, &musb->in_bulk);
needs to be replaced by equivalent (and faster) call:
list_move_tail(&cur_qh->ring, &musb->in_bulk);
Looks good, Thanks. I think it's better if you get all your suggested
changes including this one in a separate patch instead of modifying
the original one which
is already queued.
Looks like I'll have to do a patch fixing up that one as it certainly
has a design issue. musb_bulk_nak_timeout() behaves as if it can stop
and then restart URB when the NAK timeout happens by calling
musb_start_urb() BUT the latter function can only start the URB *over
again*, so iff the NAK timeout happens in the midst of transfer, such
URB just isn't going to complete.
Ideally, as this patch haven't gotten into 2.6.29-rc1, I'd like to see it
reverted and reworked by the author. Though the way thing have been happening,
I feel that I'm the one to fix all the blunders here... :-/
-Ajay
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
