On Sun, Apr 10, 2016 at 04:35:04PM +0300, Jasem Mutlaq wrote:
> Adding VID:PID for Straizona Focusers to cp210x driver.
>
> Signed-off-by: Jasem Mutlaq <mutlaqja@xxxxxxxxxxxxxx>
Thanks for the patch.
Try running your patch through checkpatch.pl before submitting. It would
have let you know that the patch has some white-space issues (could
also have been added by your mailer).
> ---
> drivers/usb/serial/cp210x.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index dd47823..d1bed34 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -109,6 +109,7 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x10C4, 0x826B) }, /* Cygnal Integrated Products,
> Inc., Fasttrax GPS demonstration module */
> { USB_DEVICE(0x10C4, 0x8281) }, /* Nanotec Plug & Drive */
> { USB_DEVICE(0x10C4, 0x8293) }, /* Telegesis ETRX2USB */
> + { USB_DEVICE(0x10C4, 0x82F4) }, /* Starizona MicroTouch*/
> { USB_DEVICE(0x10C4, 0x82F9) }, /* Procyon AVS */
> { USB_DEVICE(0x10C4, 0x8341) }, /* Siemens MC35PU GPRS Modem */
> { USB_DEVICE(0x10C4, 0x8382) }, /* Cygnal Integrated Products, Inc.
> */
> @@ -118,6 +119,7 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x10C4, 0x8418) }, /* IRZ Automation Teleport SG-10
> GSM/GPRS Modem */
> { USB_DEVICE(0x10C4, 0x846E) }, /* BEI USB Sensor Interface (VCP) */
> { USB_DEVICE(0x10C4, 0x8477) }, /* Balluff RFID */
> + { USB_DEVICE(0x10C4, 0x84B6) }, /* Starizona Hyperion*/
Missing space before *.
> { USB_DEVICE(0x10C4, 0x85EA) }, /* AC-Services IBUS-IF */
> { USB_DEVICE(0x10C4, 0x85EB) }, /* AC-Services CIS-IBUS */
> { USB_DEVICE(0x10C4, 0x85F8) }, /* Virtenio Preon32 */
Looks good otherwise.
Care to fix that up and resend?
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
