On Mon, Apr 18, 2016 at 01:41:38PM +1000, Mike Manning wrote:
> Please find attached patch file for addition of Link G4 and Link G4+ Ecu's.
Thanks for the patch.
Try running your patch through scripts/checkpath.pl before submitting.
It would have let you know that the patch has some whitespace issues
(leading spaces instead of tabs).
Also make sure to send the patch inline rather than as an attachment.
git format-patch and git send-email are very convenient to get this
right.
> From a705ab11807ee600b9252f15681f64a346377629 Mon Sep 17 00:00:00 2001
> Subject: [PATCH] cp210x: Add ID for Link ECU
> From: Mike Manning <michael@xxxxxxxxxxx>
>
> The Link ECU is an aftermarket ECU computer for vehicles that provides full
> tuning abilities as well as datalogging and displaying capabilities via
> the USB to Serial adapter built into the device.
> Date: Mon, 18 Apr 2016 02:21:01 +0000
There shouldn't be a date field here.
> Signed-off-by: Michael Manning <michael@raspberrypi.(none)>
And this address looks wrong?
> ---
> drivers/usb/serial/cp210x.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index bdc0f2f..7f45d00 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -140,6 +140,8 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x10C4, 0xF004) }, /* Elan Digital Systems USBcount50 */
> { USB_DEVICE(0x10C5, 0xEA61) }, /* Silicon Labs MobiData GPRS USB Modem */
> { USB_DEVICE(0x10CE, 0xEA6A) }, /* Silicon Labs MobiData GPRS USB Modem 100EU */
> + { USB_DEVICE(0x12B8, 0xEC60) }, /* Link G4 ECU */
> + { USB_DEVICE(0x12B8, 0xEC62) }, /* Link G4+ ECU */
> { USB_DEVICE(0x13AD, 0x9999) }, /* Baltech card reader */
> { USB_DEVICE(0x1555, 0x0004) }, /* Owen AC4 USB-RS485 Converter */
> { USB_DEVICE(0x166A, 0x0201) }, /* Clipsal 5500PACA C-Bus Pascal Automation Controller */
Care to fix that up and resend?
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
