RE: [PATCH] MUSB: Resume suspended root hub when a disconnect event occurs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: linux-usb-owner@xxxxxxxxxxxxxxx On Behalf Of Gadiyar, Anand
> Sent: Monday, November 24, 2008 7:23 PM
> To: felipe.balbi@xxxxxxxxx; linux-usb
> Subject: RE: [PATCH] MUSB: Resume suspended root hub when a  disconnect event occurs
> 
> > -----Original Message-----
> > From: linux-usb-owner@xxxxxxxxxxxxxxx On Behalf Of Gadiyar, Anand
> > Sent: Friday, November 14, 2008 6:51 PM
> > To: linux-usb
> > Cc: felipe.balbi@xxxxxxxxx
> > Subject: [PATCH] MUSB: Resume suspended root hub when a disconnect event occurs
> > 
> > From: Anand Gadiyar <gadiyar@xxxxxx>
> > 
> > If this is not done, khubd will not be informed of the disconnect
> > and will assume the device is still there.
> > 
> > Easily seen when a hub is connected with no device attached to it -
> > it will autosuspend. When the hub is disconnected, it still shows
> > up in /proc/bus/usb/devices
> > 
> > Signed-off-by: Anand Gadiyar <gadiyar@xxxxxx>
> > ---
> > I'm not sure if this is the right place to call usb_hcd_resume_root_hub()
> > or if this should be done within musb_root_disconnect().
> > 
> 
> 
> Felipe, all,
> 
> Any comments on this patch?
> 
> - Anand
> 

I seem to have forgotten about this patch and so has everyone else.

Felipe, any comments. If not, care to queue this up?

- Anand
> 
> > diff --git a/drivers/usb/musb/musb_core.c 
> > b/drivers/usb/musb/musb_core.c
> > index 4a35745..1a00370 100644
> > --- a/drivers/usb/musb/musb_core.c
> > +++ b/drivers/usb/musb/musb_core.c
> > @@ -766,6 +766,7 @@ static irqreturn_t musb_stage2_irq(struct 
> > musb *musb, u8 int_usb,
> >  #ifdef CONFIG_USB_MUSB_HDRC_HCD
> >  		case OTG_STATE_A_HOST:
> >  		case OTG_STATE_A_SUSPEND:
> > +			usb_hcd_resume_root_hub(musb_to_hcd(musb));
> >  			musb_root_disconnect(musb);
> >  			if (musb->a_wait_bcon != 0)
> >  				musb_platform_try_idle(musb, jiffies
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux