Re: [PATCH 1/1] usb: lpm: add boot flag to disable lpm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oliver Neukum <oneukum@xxxxxxxx> writes:
> On Wed, 2016-04-13 at 14:33 -0700, Greg KH wrote:
>
>> But larger issue, no new module parameters for things like this.  No one
>> will use them and they aren't device or bus specific.  It's a huge
>> hammer that isn't nice to use.
>
> But this is a valuable debug tool.

Even more valuable when you make it device or bus specific.  I don't see
Greg arguing against a knob to turn off LPM.  Only the slegde hammer
operated master switch implementation :)

I recently started thinking about ways to make it easier to test/debug
all (or at least most of) the USB quirks. I stopped after discovering
that I didn't need the new quirk I thought I needed after all..  But the
idea was something along the lines of reusing the dynamic ID code in the
quirk processing. The "usb" driver could have a "new_id" (but let's call
it something else please) attribute, allowing writing a device ID and
quirk flag.  Reading the attribute should give you a list of all current
quirks.  The quirk processing is based on the common device matching
code, so adding dynamic device id matching should be a piece of cake
(FLW). 

Whatdoyouthink?  Yes, I know - too much talk and too little code.  I'll
see if I can come up with an RFC patch if noone else does in the mean
time.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux