On 4/13/2016 11:52 AM, Dinh Nguyen wrote:
> On 04/13/2016 11:23 AM, Stefan Wahren wrote:
>
>>> + hsotg->reset = devm_reset_control_get(hsotg->dev, "dwc2");
>>
>> shouldn't this be documented in Documentation/devicetree/bindings/usb/dwc2.txt ?
>>
>
> Sure, I can document it.
>
>>> + if (IS_ERR(hsotg->reset)) {
>>> + dev_info(hsotg->dev, "Could not get reset control!\n");
>>> + if (PTR_ERR(hsotg->reset) == -EPROBE_DEFER)
>>> + return -EPROBE_DEFER;
>>
>> If this log message is really necessary, please move it down here and add the error code into the message.
>>
>
> Will do. Thanks for the review.
Also could you downgrade it to dev_dbg() and remove the "!".
Thanks,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
