Hi,
Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> writes:
>> diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
>> index 43576ed31ccd..b7735c9850f8 100644
>> --- a/drivers/usb/storage/usb.c
>> +++ b/drivers/usb/storage/usb.c
>> @@ -594,6 +594,10 @@ static int get_device_info(struct us_data *us, const struct usb_device_id *id,
>> return -ENODEV;
>> }
>>
>> + /* Flag USB3 devices so we can increase max_sectors to 2048 sectors. */
>> + if (dev->speed == USB_SPEED_SUPER)
>> + us->fflags |= US_FL_USB3;
>> +
>> /*
>> * This flag is only needed when we're in high-speed, so let's
>> * disable it if we're in full-speed
>> diff --git a/include/linux/usb_usual.h b/include/linux/usb_usual.h
>> index 7f5f78bd15ad..b76b0faaedc8 100644
>> --- a/include/linux/usb_usual.h
>> +++ b/include/linux/usb_usual.h
>> @@ -79,6 +79,8 @@
>> /* Cannot handle MI_REPORT_SUPPORTED_OPERATION_CODES */ \
>> US_FLAG(MAX_SECTORS_240, 0x08000000) \
>> /* Sets max_sectors to 240 */ \
>> + US_FLAG(USB3, 0x10000000) \
>> + /* This is a USB3 Storage Device */ \
>>
>> #define US_FLAG(name, value) US_FL_##name = value ,
>> enum { US_DO_ALL_FLAGS };
>
> Aside from the multi-line comment formatting, you should avoid adding a
I can fix the multiline comment style, but I'm merely following what's
already in the file. What do people prefer in this case ? How about a
patch 3/3 fixing comment style in all drivers/usb/storage/ ?
> new bitflag. It's not necessary in this case because it's easy to test
> the connection speed directly:
>
> if (us->pusbdev->speed >= USB_SPEED_SUPER) {
thanks, fixed locally :-)
--
balbi
Attachment:
signature.asc
Description: PGP signature
