Hi,
(please make sure to break your lines at
80-characters. Documentation/email-clients.txt has several tips for
different email clients ;-))
"Du, Changbin" <changbin.du@xxxxxxxxx> writes:
>> > @@ -648,6 +687,12 @@ int dwc3_debugfs_init(struct dwc3 *dwc)
>> > goto err1;
>> > }
>> >
>> > + file = debugfs_create_file("fifo", S_IRUGO, root, dwc,
>> &dwc3_fifo_fops);
>> > + if (!file) {
>> > + ret = -ENOMEM;
>>
>> Um, no, that's not the error here. You shouldn't care at all about
>> debugfs api call results. Just keep moving on here please.
>>
>> thanks,
>>
>> greg k-h
>
> Agree with you. I will create another patch to cleanup this piece of
> code.
cool, thanks
> And I found a memory leak issue there, dwc->regset never
> released. Will also fix it.
good catch, thanks for fixing it.
--
balbi
Attachment:
signature.asc
Description: PGP signature
