Re: [PATCH 2/6] usb: dwc3: omap: don't access DMA bits directly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Grygorii Strashko <grygorii.strashko@xxxxxx> writes:
> On 04/02/2016 11:28 AM, Felipe Balbi wrote:
>> Instead of having a static global just for
>> initializing dma_mask directly, let's use
>> dma_coerce_mask_and_coherent() for that.
>> 
>> Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>
>> ---
>>   drivers/usb/dwc3/dwc3-omap.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>> 
>> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
>> index 22e9606d8e08..c219118bfda0 100644
>> --- a/drivers/usb/dwc3/dwc3-omap.c
>> +++ b/drivers/usb/dwc3/dwc3-omap.c
>> @@ -331,8 +331,6 @@ static void dwc3_omap_disable_irqs(struct dwc3_omap *omap)
>>   	dwc3_omap_write_irqmisc_clr(omap, reg);
>>   }
>>   
>> -static u64 dwc3_omap_dma_mask = DMA_BIT_MASK(32);
>> -
>>   static int dwc3_omap_id_notifier(struct notifier_block *nb,
>>   	unsigned long event, void *ptr)
>>   {
>> @@ -490,7 +488,7 @@ static int dwc3_omap_probe(struct platform_device *pdev)
>>   	omap->irq	= irq;
>>   	omap->base	= base;
>>   	omap->vbus_reg	= vbus_reg;
>> -	dev->dma_mask	= &dwc3_omap_dma_mask;
>> +	dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(32));
>
> I think, It'll be better to just remove DMA configuration code
> from this driver and other drivers which support DT-boot mode only.

I don't have HW, can you test that on AM57x and/or AM437x ?

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux