Just to recap:
The description of the original patch d8f00cd685f5 ("usb: hub: do not
clear BOS field during reset device") indicates that it fixes an oops,
but it also had a bug that introduced a different oops (reported by
me). That patch has now been reverted in mainline, fixing the new oops
that I reported but AFAIK re-introducing the original oops. Changbin
has also posted an updated patch that fixes both the original oops and
the new oops ("usb: hub: fix panic caused by NULL bos pointer during
reset device"), but that patch has not yet been merged into mainline.
So perhaps it would be better to merge Changbin's new patch into
mainline and backport that to -stable also, so that both oopses get fixed.
As far as testing goes, Changbin posted a small patch in the thread "Re:
USB oops regression caused by -stable patch", which I tested and it
fixed the oops that I found. But that small patch was before the
original patch d8f00cd685f5 was reverted. Changbin's new patch ("usb:
hub: fix panic caused by NULL bos pointer during reset device") is
equivalent to un-reverting d8f00cd685f5 and applying the small patch
that I already tested. So my testing also applies to Changbin's new patch.
Tony Battersby
Cybernetics
On 04/04/2016 05:26 AM, Roger Quadros wrote:
> Hi Greg,
>
> This commit [1] mentions that it affects certain stable versions but
> I didn't see cc: stable in it nor could find it in any mailing list.
>
> Just wanted to bring to your attention. Thanks.
>
> cheers,
> -roger
>
> [1]
> commit e5bdfd50d6f76077bf8441d130c606229e100d40
> Author: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> Revert "usb: hub: do not clear BOS field during reset device"
>
> This reverts commit d8f00cd685f5c8e0def8593e520a7fef12c22407.
>
> Tony writes:
>
> This upstream commit is causing an oops:
> d8f00cd685f5 ("usb: hub: do not clear BOS field during reset device")
>
> This patch has already been included in several -stable kernels. Here
> are the affected kernels:
> 4.5.0-rc4 (current git)
> 4.4.2
> 4.3.6 (currently in review)
> 4.1.18
> 3.18.27
> 3.14.61
>
> How to reproduce the problem:
> Boot kernel with slub debugging enabled (otherwise memory corruption
> will cause random oopses later instead of immediately)
> Plug in USB 3.0 disk to xhci USB 3.0 port
> dd if=/dev/sdc of=/dev/null bs=65536
> (where /dev/sdc is the USB 3.0 disk)
> Unplug USB cable while dd is still going
> Oops is immediate:
>
> Reported-by: Tony Battersby <tonyb@xxxxxxxxxxxxxxx>
> Cc: Du, Changbin <changbin.du@xxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
