On 03/31/2016 11:04 AM, Felipe Balbi wrote: > "Thang Q. Nguyen" <tqnguyen@xxxxxxx> writes: >> [ text/plain ] >> Thanks Grygorii for information. >> I checked but do not see dma_init_dev_from_parent is used in >> linux-next repository. Can you give me more information for what >> branch I can checkout to use it for USB DWC3? > > dma_init_dev_from_parent() is still a proposal ;-) > Felipe, After some experiments I came up with below fix (not common, but fixes USB case on keystone 2). if you agree with proposed fix I'll send proper patches to fix usb_add_gadget_udc_release() and dwc3_host_init() in the same way. diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c index c679f63..3fe1c65 100644 --- a/drivers/usb/dwc3/host.c +++ b/drivers/usb/dwc3/host.c @@ -17,6 +17,7 @@ #include <linux/platform_device.h> #include <linux/usb/xhci_pdriver.h> +#include <linux/of_device.h> #include "core.h" @@ -35,8 +36,6 @@ int dwc3_host_init(struct dwc3 *dwc) dma_set_coherent_mask(&xhci->dev, dwc->dev->coherent_dma_mask); xhci->dev.parent = dwc->dev; - xhci->dev.dma_mask = dwc->dev->dma_mask; - xhci->dev.dma_parms = dwc->dev->dma_parms; dwc->xhci = xhci; @@ -62,6 +61,12 @@ int dwc3_host_init(struct dwc3 *dwc) phy_create_lookup(dwc->usb3_generic_phy, "usb3-phy", dev_name(&xhci->dev)); + if (!dwc->dev->of_node) { + xhci->dev.dma_mask = dwc->dev->dma_mask; + xhci->dev.dma_parms = dwc->dev->dma_parms; + } else + of_dma_configure(&xhci->dev, dwc->dev->of_node); + ret = platform_device_add(xhci); if (ret) { dev_err(dwc->dev, "failed to register xHCI device\n"); -- regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html