Re: [PATCH v10 1/9] dt-bindings: phy: Add NVIDIA Tegra XUSB pad controller binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2016-03-29 at 19:08 +0200, Thierry Reding wrote:
> On Tue, Mar 29, 2016 at 05:24:59PM +0200, Marcel Ziswiler wrote:
> > 
> > Hi Thierry
> > 
> > On Fri, 2016-03-04 at 17:19 +0100, Thierry Reding wrote:
> > > 
> > > From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane
> > > .org
> > > > 
> > > > 
> > > The NVIDIA Tegra XUSB pad controller provides a set of pads, each
> > > with a
> > > set of lanes that are used for PCIe, SATA and USB.
> > I finally got around trying this both on Jetson TK1 as well as our
> > own
> > Toradex Apalis TK1 module we are about to mainline.
> Looking forward to it.

Yes, I'm just running some final tests.

> > 
> >                                                     I actually
> > applied
> > your patch set on top of 4.6.0-rc1. While USB 3.0 seems to work
> > fine I
> > noticed PCIe and SATA no more to come up right with the following
> > message:
> > 
> > [    2.794458] tegra-pcie 1003000.pcie-controller: PLL failed to
> > lock:
> > -110
> > [    2.801177] tegra-pcie 1003000.pcie-controller: failed to power
> > on
> > PHY: -110
> > [    2.809031] tegra-pcie: probe of 1003000.pcie-controller failed
> > with
> > error -110
> > 
> > Do you happen to know what could be the issue?
> That's to be expected. You'll need this one:
> 
> 	http://patchwork.ozlabs.org/patch/596548/
> 
> which I had hoped would make v4.6-rc1, but didn't. I'll have to
> respin
> and send out again. I didn't know that SATA failed in the same way,
> but
> I'll need to recheck and see if it needs a similar change.

Ah, I missed that one which you already sent out a v3 still applying
perfectly:

http://article.gmane.org/gmane.linux.ports.tegra/25396

With that it looks much better again:

ubuntu@tegra-ubuntu:~$ lspci
00:02.0 PCI bridge: NVIDIA Corporation TegraK1 PCIe x1 Bridge (rev a1)
01:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd.
RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 0c)

I also found a more capable test device:

ubuntu@tegra-ubuntu:~$ sudo hdparm -t /dev/sda

/dev/sda:
 Timing buffered disk reads: 576 MB in  3.01 seconds = 191.55 MB/sec

However on Apalis TK1 this broke the second USB 3.0 host port which now
refuses to work. Still works plugging in USB 2.0 gear though.

Hm, it works if plugged in during boot. Strange. What could be the
issue if hot-plugging USB 3.0 devices on the second port does not quite
work?

I'm also wondering whether the Tegra EHCI stuff is still required as
there are now quite many USB buses showing up:

ubuntu@tegra-ubuntu:~$ lsusb
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 005 Device 002: ID 174c:07d1 ASMedia Technology Inc.
Bus 005 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 004 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

I also noticed xhci to register lots of ports:

[    3.603688] tegra-xusb 70090000.usb: Firmware timestamp: 2014-09-16
02:10:07 UTC
[    3.611109] tegra-xusb 70090000.usb: xHCI Host Controller
[    3.616560] tegra-xusb 70090000.usb: new USB bus registered,
assigned bus number 4
[    3.626052] tegra-xusb 70090000.usb: hcc params 0x0184f525 hci
version 0x100 quirks 0x00010010
[    3.634738] tegra-xusb 70090000.usb: irq 346, io mem 0x70090000
[    3.641572] hub 4-0:1.0: USB hub found
[    3.645404] hub 4-0:1.0: 6 ports detected

And:

[    3.650144] tegra-xusb 70090000.usb: xHCI Host Controller
[    3.655599] tegra-xusb 70090000.usb: new USB bus registered,
assigned bus number 5
[    3.663267] usb usb5: We don't know the algorithms for LPM for this
host, disabling LPM.
[    3.696888] usb usb5: No SuperSpeed endpoint companion for config
1  interface 0 altsetting 0 ep 129: using minimum values
[    3.715028] hub 5-0:1.0: USB hub found
[    3.718819] hub 5-0:1.0: 2 ports detected

> > As for USB I do get some message about the endpoint companion but
> > do
> > not know whether or not this is to be expected:
> > 
> > [ 1021.575301] usb 4-1: new SuperSpeed USB device number 2 using
> > tegra-
> > xusb
> > [ 1021.598913] usb 4-1: No SuperSpeed endpoint companion for config
> > 1  interface 0 altsetting 0 ep 2: using minimum values
> I'm not exactly sure why that message appears, but I think it is
> harmless.

OK. Yes, at least it does not seem to have any adverse effects.

> > Otherwise it looks good:
> > 
> > ubuntu@tegra-ubuntu:~$ lsusb
> > Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > Bus 004 Device 002: ID 0951:1666 Kingston Technology DataTraveler
> > G4
> > Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
> > Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > 
> > And performs satisfactorily (up from around 24 MB/sec with just USB
> > 2.0):
> > 
> > ubuntu@tegra-ubuntu:~$ sudo hdparm -t /dev/sda
> > 
> > /dev/sda:
> >  Timing buffered disk reads:  94 MB in  3.05 seconds =  30.81
> > MB/sec
> > 
> > Apalis TK1 actually features two USB 3.0 host ports:
> > 
> > ubuntu@tegra-ubuntu:~$ lsusb
> > Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > Bus 005 Device 002: ID 0951:1666 Kingston Technology DataTraveler
> > G4
> > Bus 005 Device 003: ID 1f75:0902 Innostor Technology Corporation
> > IS902
> > UFD controller
> > Bus 005 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
> > Bus 004 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > 
> > ubuntu@tegra-ubuntu:~$ sudo hdparm -t /dev/sda
> > 
> > /dev/sda:
> >  Timing buffered disk reads:  96 MB in  3.00 seconds =  31.98
> > MB/sec
> > 
> > ubuntu@tegra-ubuntu:~$ sudo hdparm -t /dev/sdb
> > 
> > /dev/sdb:
> >  Timing buffered disk reads: 152 MB in  3.04 seconds =  49.99
> > MB/sec
> Looking great. Thanks for testing.

Thank you.

BTW: Does any of you make it to GTC this year? I will attend and
Toradex is showcasing its latest Apalis TK1 module.

> Thierry


Cheers

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux