On Mon, 2016-03-21 at 11:46 -0400, Alan Stern wrote: > On Mon, 21 Mar 2016, Oliver Neukum wrote: > > > On Fri, 2016-03-18 at 12:36 -0400, Alan Stern wrote: > > > > Almost. In case of reset_resume() it makes no sense to still > > clear a halt or execute a reset that had been ordered. The > > corresponding flags should be cleared. > > hid_post_reset() already clears the HID_RESET_PENDING flag. It also > needs to clear the HID_CLEAR_HALT flag; I'll add that in. > > > And now that I think of it, if while restarting IO an > > old error condition is detected shouldn't the restart wait for > > the error to be handled? > > Yes; we should avoid starting I/O if a reset is pending and we should > avoid starting the interrupt-IN URB if a clear-halt is pending. How > does this patch look? Perfect. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html