On 03/16/2016 08:58 PM, David Lechner wrote:
+static struct clk usb20_clk = { + .name = "usb20", + .parent = &pll0_sysclk2, + .lpsc = DA8XX_LPSC1_USB20, + .gpsc = 1, +};Why move it?For organization, to keep all of the USB clocks together. I can leave it alone if that is preferred.
I'd prefer to minimize the noise...
+ + /* Set the mux depending on the parent clock. */ + if (clk->parent == &pll0_aux_clk) + val |= CFGCHIP2_USB2PHYCLKMUX; + else if (clk->parent == &usb_ref_clk) + val &= ~CFGCHIP2_USB2PHYCLKMUX;Don't we have clk_set_parent()for that?Yes. clk_set_parent() is already called in a loop for all clocks elsewhere, so not needed here.
No, I mean why is not this implemented as a part of clk_set_parent()? MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
