RE: [PATCH v2 2/2] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> writes:
> 
> > [ text/plain ]
> > This patch fixes an issue that cannot work if R-Car Gen2/3 run on
> > above 4GB physical memory environment to use a quirk XHCI_CLEAR_AC64.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > ---
> >  drivers/usb/host/xhci-plat.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> > index 5c15e9b..4dbd56f 100644
> > --- a/drivers/usb/host/xhci-plat.c
> > +++ b/drivers/usb/host/xhci-plat.c
> > @@ -39,12 +39,19 @@ static const struct xhci_driver_overrides xhci_plat_overrides __initconst = {
> >
> >  static void xhci_plat_quirks(struct device *dev, struct xhci_hcd *xhci)
> >  {
> > +	struct usb_hcd *hcd = xhci_to_hcd(xhci);
> > +
> >  	/*
> >  	 * As of now platform drivers don't provide MSI support so we ensure
> >  	 * here that the generic code does not try to make a pci_dev from our
> >  	 * dev struct in order to setup MSI
> >  	 */
> >  	xhci->quirks |= XHCI_PLAT;
> > +
> > +	/* Please refer to the xhci.c about the detail of this quirk */
> 
> this is an odd comment. It should be okay to state here that RCAR
> GEN2/GEN3 lack proper 64BIT support even though register says otherwise.

Thank you for the comment. I will add comments like a patch v1.

Best regards,
Yoshihiro Shimoda

> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux